Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move AppModule.BeginBlock and AppModule.EndBlock to extension interfaces (backport #12603) #12638

Merged
merged 4 commits into from
Jul 19, 2022

Commits on Jul 19, 2022

  1. feat: Move AppModule.BeginBlock and AppModule.EndBlock to extension i…

    …nterfaces (#12603)
    
    ## Description
    Most modules right now have a no-op for AppModule.BeginBlock and AppModule.EndBlock. We should move these methods off the AppModule interface so we have less deadcode, and instead move them to extension interfaces.
    
    1. I added `BeginBlockAppModule` and `EndBlockAppModule` interface.
    2. Remove the dead-code from modules that do no implement them
    3. Add type casting in the the module code to use the new interface
    
    Closes: #12462
    
    ---
    
    ### Author Checklist
    
    *All items are required. Please add a note to the item if the item is not applicable and
    please add links to any relevant follow up issues.*
    
    I have...
    
    - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] added `!` to the type prefix if API or client breaking change
    - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
    - [ ] provided a link to the relevant issue or specification
    - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
    - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
    - [ ] added a changelog entry to `CHANGELOG.md`
    - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
    - [ ] updated the relevant documentation or specification
    - [ ] reviewed "Files changed" and left comments if necessary
    - [ ] confirmed all CI checks have passed
    
    ### Reviewers Checklist
    
    *All items are required. Please add a note if the item is not applicable and please add
    your handle next to the items reviewed if you only reviewed selected items.*
    
    I have...
    
    - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] confirmed `!` in the type prefix if API or client breaking change
    - [ ] confirmed all author checklist items have been addressed
    - [ ] reviewed state machine logic
    - [ ] reviewed API design and naming
    - [ ] reviewed documentation is accurate
    - [ ] reviewed tests and test coverage
    - [ ] manually tested (if applicable)
    
    (cherry picked from commit b65f3fe)
    
    # Conflicts:
    #	CHANGELOG.md
    #	x/authz/module/module.go
    #	x/group/module/module.go
    #	x/nft/module/module.go
    #	x/params/module.go
    #	x/slashing/module.go
    #	x/upgrade/module.go
    stackman27 authored and mergify[bot] committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    6a1f385 View commit details
    Browse the repository at this point in the history
  2. remove conflicts

    tac0turtle committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    283cdec View commit details
    Browse the repository at this point in the history
  3. remove conflicts

    tac0turtle committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    99943f4 View commit details
    Browse the repository at this point in the history
  4. remove unused modules

    tac0turtle committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    f3efb33 View commit details
    Browse the repository at this point in the history