Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add core module API #12239
feat: add core module API #12239
Changes from 21 commits
c59fef9
8251594
204cd7a
afcdbcd
964f481
80fb734
91c7b8f
40d493a
b432e37
963bbae
81049cd
68abaa7
8ade043
4de0773
024f366
b7e175b
33f99b2
8e0f531
3c6b412
25acd02
807c2e0
043b6fb
7f9b15c
da5e6c2
be1e98c
a6d2531
daac685
b2e0881
fb3a5e6
1081d45
f9d2522
3cbe6c5
dfe781d
2635c0b
6a6fc51
ac62df1
260077d
3ccd485
5328e62
002d9d2
b1ae3f9
f9a903d
481d107
6db3f0a
0438fdc
8b27a49
fdc9933
f5dd33a
0c28208
6e5b9c7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe you can mention some hooks here, or point where these hooks are defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added an example with the
ValidatorUpdateService
in this PR and described this more in the ADR