Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename GenTx to GenSignedMockTx to avoid confusion with genutil/GenTx #11696

Merged
merged 4 commits into from
Apr 20, 2022

Conversation

anilcse
Copy link
Collaborator

@anilcse anilcse commented Apr 20, 2022

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #11696 (bc70a88) into master (1042373) will decrease coverage by 0.02%.
The diff coverage is 94.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11696      +/-   ##
==========================================
- Coverage   65.92%   65.90%   -0.03%     
==========================================
  Files         667      667              
  Lines       70446    70462      +16     
==========================================
- Hits        46441    46437       -4     
- Misses      21307    21328      +21     
+ Partials     2698     2697       -1     
Impacted Files Coverage Δ
simapp/test_helpers.go 26.72% <0.00%> (ø)
types/coin.go 93.11% <ø> (ø)
x/genutil/client/cli/gentx.go 0.00% <0.00%> (ø)
x/simulation/util.go 0.00% <0.00%> (ø)
x/authz/simulation/operations.go 66.97% <100.00%> (ø)
x/bank/simulation/operations.go 81.02% <100.00%> (ø)
x/genutil/client/testutil/suite.go 100.00% <100.00%> (ø)
x/gov/simulation/operations.go 85.31% <100.00%> (ø)
x/group/simulation/operations.go 67.73% <100.00%> (ø)
x/nft/simulation/operations.go 69.30% <100.00%> (ø)
... and 3 more

@alexanderbez alexanderbez added backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release backport/0.44.x labels Apr 20, 2022
@alexanderbez alexanderbez merged commit 1a9654f into master Apr 20, 2022
@alexanderbez alexanderbez deleted the anil/refactor_test_helpers branch April 20, 2022 15:27
mergify bot pushed a commit that referenced this pull request Apr 20, 2022
mergify bot pushed a commit that referenced this pull request Apr 20, 2022
… genutil/GenTx (#11696)

(cherry picked from commit 1a9654f)

# Conflicts:
#	CHANGELOG.md
#	x/group/simulation/operations.go
#	x/nft/simulation/operations.go
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release C:Simulations C:x/authz C:x/bank C:x/genutil genutil module issues C:x/gov C:x/group C:x/nft C:x/slashing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants