Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: --max-msgs with generate-only should not throw error #10842

Merged
merged 31 commits into from
Jan 18, 2022
Merged

fix: --max-msgs with generate-only should not throw error #10842

merged 31 commits into from
Jan 18, 2022

Conversation

atheeshp
Copy link
Contributor

Description

Closes: #10841

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added C:CLI C:x/distribution distribution module related labels Dec 27, 2021
@atheeshp atheeshp changed the title fix: --max-msgs with generate-only should throw error fix: --max-msgs with generate-only should not throw error Dec 27, 2021
@atheeshp atheeshp marked this pull request as ready for review January 3, 2022 09:27
@atheeshp atheeshp requested a review from ebuchman January 3, 2022 09:28
@amaury1093 amaury1093 self-assigned this Jan 3, 2022
amaury1093
amaury1093 reviewed Jan 6, 2022
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall, we should add a changelog entry

x/distribution/client/testutil/suite.go Outdated Show resolved Hide resolved
x/distribution/client/testutil/suite.go Outdated Show resolved Hide resolved
atheeshp
atheeshp commented Jan 7, 2022
View reviewed changes
x/distribution/client/testutil/cli_test.go
@@ -19,3 +20,9 @@ func TestIntegrationTestSuite(t *testing.T) {
func TestGRPCQueryTestSuite(t *testing.T) {
suite.Run(t, new(GRPCQueryTestSuite))
}

func TestWithdrawAllSuite(t *testing.T) {
Copy link
Contributor Author

@atheeshp atheeshp Jan 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a new suite here, since there are few tests are failing if I change NumValidators = 2 in existing integration suite (seems like non-determinism) and couldn't test them on local machine since the tests are keep on throwing timeout error.

atheeshp
atheeshp commented Jan 8, 2022
View reviewed changes
x/distribution/client/testutil/suite.go
@@ -709,7 +727,7 @@ func (s *IntegrationTestSuite) TestGetCmdSubmitProposal() {
invalidPropFile.Name(),
fmt.Sprintf("--%s=%s", flags.FlagFrom, val.Address.String()),
fmt.Sprintf("--%s=true", flags.FlagSkipConfirmation),
fmt.Sprintf("--%s=%s", flags.FlagBroadcastMode, flags.BroadcastSync),
fmt.Sprintf("--%s=%s", flags.FlagBroadcastMode, flags.BroadcastBlock),
Copy link
Contributor Author

@atheeshp atheeshp Jan 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated this (made changes accordingly), because some times tests are getting timeout with BroadcastSync.

@atheeshp
Copy link
Contributor Author

atheeshp commented Jan 10, 2022 •
edited
Loading

@alexanderbez can you have another look please, few changes have been made after your approval. Thanks!

amaury1093
amaury1093 approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, but the non-determinism/timeouts seems a bit worrying. If we merge this, can we maybe create an issue to track this?

@amaury1093
Copy link
Contributor

ping @alexanderbez, would you have bandwidth to take another look at this PR?

@alexanderbez
Copy link
Contributor

changes lgtm, but the non-determinism/timeouts seems a bit worrying. If we merge this, can we maybe create an issue to track this?

Are you referring to the simulation non-determinism? If so, yeah that's very worrying and I would hestitate to merge this PR with those failing. But why does a CLI change impact those?

@atheeshp
Copy link
Contributor Author

changes lgtm, but the non-determinism/timeouts seems a bit worrying. If we merge this, can we maybe create an issue to track this?

Are you referring to the simulation non-determinism? If so, yeah that's very worrying and I would hestitate to merge this PR with those failing. But why does a CLI change impact those?

No, this is not about simulations non-determinism, I was mentioning in integration tests itself there were few tests continuously producing different delegation rewards all the time.

@alexanderbez
Copy link
Contributor

changes lgtm, but the non-determinism/timeouts seems a bit worrying. If we merge this, can we maybe create an issue to track this?

Are you referring to the simulation non-determinism? If so, yeah that's very worrying and I would hestitate to merge this PR with those failing. But why does a CLI change impact those?

No, this is not about simulations non-determinism, I was mentioning in integration tests itself there were few tests continuously producing different delegation rewards all the time.

That shouldn't be possible unless there is variance in how many blocks we wait between txs and/ queries.

@blushi blushi added the A:automerge Automatically merge PR once all prerequisites pass. label Jan 18, 2022
@mergify mergify bot merged commit 43cf8eb into master Jan 18, 2022
@mergify mergify bot deleted the ap/max-msgs-all-rewards branch January 18, 2022 14:17
@amaury1093 amaury1093 mentioned this pull request May 23, 2022
Closed
72 tasks
@mpoke mpoke mentioned this pull request Nov 29, 2023
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaury1093 amaury1093 amaury1093 approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees

@amaury1093 amaury1093

Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/distribution distribution module related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setting --max-msgs along with --generate-only gives error
4 participants
@atheeshp @amaury1093 @alexanderbez @blushi