fix!: force genOrBroadcastFn even when max-msgs != 0
#10477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
0Tech
force-pushed
the
0Tech/cli-dist-withdraw-all
branch
from
9f2d0f0
to
632c858
Compare
If cli tx withdraw-all-rewards sends empty tx, the tx would be rejected by validators because it has no msgs. However, the cli sends empty tx only if one sets `--max-msgs=0` which means it does not split the msgs. When you set `max-msgs` with any positive number, the cli does not send any tx, which may confuse you because you cannot get the feedback indicating the address has no delegations. This patch addresses the problem, by forcing genOrBroadcastFn when the number of total msgs generated is zero. It will provide the same user experience with any `max-msgs`.
0Tech
force-pushed
the
0Tech/cli-dist-withdraw-all
branch
from
632c858
to
3a791e3
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
amaury1093
reviewed
Jan 3, 2022
|
|
||
| if chunkSize == 0 { | ||
| totalMessages := len(msgs) | ||
| if chunkSize == 0 || totalMessages == 0 { | ||
| return genOrBroadcastFn(clientCtx, fs, msgs...) |
There was a problem hiding this comment.
Why would be broadcast a tx with 0 msgs if it's going to be rejected by the node? Shouldn't we just throw an error early?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If cli tx withdraw-all-rewards sends empty tx, the tx would be
rejected by validators because it has no msgs. However, the cli sends
empty tx only if one sets
--max-msgs=0which means it does not splitthe msgs. When you set
max-msgswith any positive number, the clidoes not send any tx, which may confuse you because you cannot get the
feedback indicating the address has no delegations.
This patch addresses the problem, by forcing genOrBroadcastFn when the
number of total msgs genreated is zero. It will provide the same user
experience with any
max-msgs.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change