Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for setting StoreLoader as part of in-place store migration documentation #9503

Closed
clevinson opened this issue Jun 11, 2021 · 0 comments · Fixed by #9526
Closed

Add documentation for setting StoreLoader as part of in-place store migration documentation #9503

clevinson opened this issue Jun 11, 2021 · 0 comments · Fixed by #9526
Assignees
@likhita-809
Labels
T:Docs Changes and features related to documentation.
Milestone
v0.43

Comments

@clevinson
Copy link
Contributor

clevinson commented Jun 11, 2021 •
edited by amaury1093
Loading

When doing in-place store migrations and introducing new modules, we need to add StoreUpgrades for the new modules in the upgrade process. The in-place migration docs (https://docs.cosmos.network/master/core/upgrade.html) should mention this.

See #9381 for how it should be done.
@clevinson clevinson added this to the v0.43 milestone Jun 11, 2021
@amaury1093 amaury1093 added the T:Docs Changes and features related to documentation. label Jun 11, 2021
@likhita-809 likhita-809 self-assigned this Jun 16, 2021
@likhita-809 likhita-809 mentioned this issue Jun 16, 2021
Merged
13 tasks
@mergify mergify bot closed this as completed in #9526 Jun 17, 2021
mergify bot pushed a commit that referenced this issue Jun 17, 2021
@likhita-809
docs: Add docs for setting store loader (#9526)
0e64fa7 
## Description

Closes: #9503 

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

Add documentation for setting StoreLoader as part of in-place store migration.

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct `docs:` prefix in the PR title
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [ ] followed the [documentation writing guidelines](https://github.com/cosmos/cosmos-sdk/blob/master/docs/DOC_WRITING_GUIDELINES.md)
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [x] confirmed the correct `docs:` prefix in the PR title
- [ ] confirmed all author checklist items have been addressed 
- [x] confirmed that this PR only changes documentation
- [x] reviewed content for consistency
- [x] reviewed content for thoroughness
- [x] reviewed content for spelling and grammar
- [ ] tested instructions (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@likhita-809 likhita-809

Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
v0.43
Development

Successfully merging a pull request may close this issue.

docs: Add docs for setting store loader cosmos/cosmos-sdk
4 participants
@aaronc @clevinson @amaury1093 @likhita-809