Int64 overflow in Rational?

[mossid]

At line 71 of x/stake/tick.go:

inflation = pool.Inflation.Add(inflationRateChange)

Debugged variables value:

pool.Inflation: {Num:70008793 Denom:1000000000}
inflationRateChange: {Num:284048115403 Denom:32302968010554600}
inflation: {Num:1025127075753892381 Denom:-4851056627833949696}

Found while running tick_test.go

[cwgoes]

Possibly why the tests in #744 are failing, I'm seeing similar behaviour

[mossid]

ToRat at types/rational.go:127 calls big.Int.Int64() without overflow check

[rigelrozanski]

Mhmm... good catch - this was introduced when modifying rational to be go-wire compliant (in a kind of hacky way of changing the Rat object to have a Num and Denom field instead just extending big.Rat) - unfortunately I think the real solution here is to wait for go-amino integration and then revert back to extending big.Rat - right now we just have to make sure that we use explicitly use the .Round() functionality... otherwise we should panic!