Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gaiacli tx decode #3872

Closed
jackzampolin opened this issue Mar 13, 2019 · 5 comments · Fixed by #5023
Closed

gaiacli tx decode #3872

jackzampolin opened this issue Mar 13, 2019 · 5 comments · Fixed by #5023

Comments

@jackzampolin
Copy link
Member

There is a POST /tx/decode route in the rest-server. This functionality should also be available in gaiacli as tx decode

@yangyanqing
Copy link
Contributor

But there is no POST /tx/decode in route of /tx/. Shall we implement them all ? @jackzampolin

// /github.com/cosmos/cosmos-sdk/client/tx/root.go
func RegisterRoutes(cliCtx context.CLIContext, r *mux.Router, cdc *codec.Codec) {
	r.HandleFunc("/txs/{hash}", QueryTxRequestHandlerFn(cdc, cliCtx)).Methods("GET")
	r.HandleFunc("/txs", SearchTxRequestHandlerFn(cliCtx, cdc)).Methods("GET")
	r.HandleFunc("/txs", BroadcastTxRequest(cliCtx, cdc)).Methods("POST")
	r.HandleFunc("/txs/encode", EncodeTxRequestHandlerFn(cdc, cliCtx)).Methods("POST")
}

@alexanderbez
Copy link
Contributor

Yeah we should implement both @yangyanqing. I swear we had decoding, but I guess not.

@tnachen
Copy link
Contributor

tnachen commented Aug 30, 2019

@fedekunze you mentioned you'll be creating a new PR (#4213 (comment)). Is this done then?

@alexanderbez
Copy link
Contributor

Bump @fedekunze or perhaps @tnachen can tackle it?

@tnachen
Copy link
Contributor

tnachen commented Sep 3, 2019

I'll take this too then.

@tnachen tnachen self-assigned this Sep 3, 2019
tnachen pushed a commit that referenced this issue Sep 10, 2019
@tnachen tnachen mentioned this issue Sep 10, 2019
3 tasks
tnachen pushed a commit that referenced this issue Sep 12, 2019
tnachen pushed a commit that referenced this issue Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants