Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenDb with CLevelDB #3719

Closed
4 tasks
Stumble opened this issue Feb 22, 2019 · 1 comment
Closed
4 tasks

OpenDb with CLevelDB #3719

Stumble opened this issue Feb 22, 2019 · 1 comment
Assignees
@alessio

Comments

@Stumble
Copy link
Contributor

Stumble commented Feb 22, 2019 •
edited
Loading

Summary

If we want to use CLevelDB as the driver for application.db, currently, we need to manually change this line after dep ensure.

cosmos-sdk/server/constructors.go

Line 27 in c96d8f3

db, err := dbm.NewGoLevelDB("application", dataDir)

could we add a parameter at somewhere to specify the driver we want?

Problem Definition

Proposal

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@jackzampolin
Copy link
Member

@Stumble This is a great feature request. Can you push up a PR that adds the ability to this? Ideally we would hide cleveldb behind a build flag as the importation of C breaks cross compilation.

alessio pushed a commit that referenced this issue Mar 4, 2019
use DBBackend set at compile time
6bd6f31 
Closes: #3719
@alessio alessio self-assigned this Mar 4, 2019
@alessio alessio mentioned this issue Mar 4, 2019
Merged
5 tasks
cwgoes pushed a commit that referenced this issue Mar 4, 2019
@alessio @cwgoes
Merge PR #3792: Use DBBackend set at compile time
3e82a8b 
* use DBBackend set at compile time

Closes: #3719

* Refresh changelog

* Tweak Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alessio alessio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alessio @Stumble @jackzampolin