Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between LCD client and CLI client - slashing/signing-info #1866

Closed
4 tasks
joe-bowman opened this issue Jul 28, 2018 · 4 comments
Closed
4 tasks

Comments

@joe-bowman
Copy link
Contributor

joe-bowman commented Jul 28, 2018

Summary of Bug

gaiacli stake signing-info takes the validator public key, from which it derives the validator address.

<rest_api_endpoint>/slashing/signing_info/<validator> expects the validator address (which incidentaly I haven't been able to find? is this actually displayed/used anywhere?)

Should the REST api be updated to use the bech32valpubkey and compute the validator address from that, as per the CLI?

Steps to Reproduce

Attempt to hit REST signing-info endpoint with the same address used for identical CLI query and receive the following error: invalid bech32 prefix. Expected cosmosvaladdr, Got cosmosvalpub


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

Agreed it should be consistent.

@cwgoes
Copy link
Contributor

cwgoes commented Jul 30, 2018

I think we're getting rid of pubkeys in ABCI in favor of just passing validator addresses - so agreed on consistency but it may need to be based on address.

@joe-bowman
Copy link
Contributor Author

Sorry. Fat fingers!

@alexanderbez
Copy link
Contributor

Whoops. Closed via #1889

chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this issue Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants