-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--from should be able to take both an address and a name #1735
Comments
Sure, that seems helpful. Can we extend the concept and allow any command referencing an address to look up a name in the local DB? That way users can register public keys for known entities (e.g. their validator) under nice names and avoid mistakes. |
|
I think this will be extremely helpful. It may seem cumbersome and maybe confusing to some folks to have to provide |
I think this needs to be prioritized since the major way we are requesting users to interact with our software is through the CLI and this is a significant improvement in UX. The idea of looking up addresses in the localDB should be implemented. |
Okay - so now ( |
so much yes |
* Allow --from to be a name or an address Closes #1735. * Post-rebase fixes * Updates from code review * Updates from code review * Updates from code review * Fix merge artifacts * Fix merge conflicts * Fix integration tests * Add back GetFromName() check broken during merge * Code review updates * Fix failing test * Updates from code review
It would be convenient if
--from
would also work with a simple address. It's seem counterintuitive that sometimes you need a name and sometimes an address.The text was updated successfully, but these errors were encountered: