Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove bytes/HexBytes #15049

Closed
tac0turtle opened this issue Feb 16, 2023 · 5 comments · Fixed by #15211
Closed

refactor: remove bytes/HexBytes #15049

tac0turtle opened this issue Feb 16, 2023 · 5 comments · Fixed by #15211
Labels
good first issue T:tech debt Tech debt that should be cleaned up

Comments

@tac0turtle
Copy link
Member

Summary

Throughout the cosmos-sdk we have always used bytes.HexBytes from cmtbytes "github.com/cometbft/cometbft/libs/bytes". I have always questioned the need for this type even within tendermint. Its not an issue, but it would be nice to reduce the reliance on comet as a whole and remove this type if its not needed

Problem Definition

Not a problem

Proposal

Remove usage of bytes.HexBytes in order to reduce reliance of types from comet.

Who ever picks up this issue should first look if this change is breaking.

  • do we rely on the json encoding of the type or was this purely additive?
@tac0turtle tac0turtle added the T:tech debt Tech debt that should be cleaned up label Feb 16, 2023
@chixiaowen
Copy link
Contributor

Can i take this one? @tnachen @alexanderbez

@tac0turtle
Copy link
Member Author

tac0turtle commented Feb 24, 2023

yea, part of the worskcope would need to be to double check encoding that depended on it and provide documentation on how it chnaged for clients

@chixiaowen
Copy link
Contributor

yea, part of the worskcope would need to be to double check encoding that depended on it and provide documentation on how it chnaged for clients

ok, and where is the specific documentation that I can modify?

@tac0turtle
Copy link
Member Author

You would add it to upgrading.md

@chixiaowen
Copy link
Contributor

@tac0turtle I have submitted a pr that marked as Draft, you can now review my pr and give me some suggestions。

julienrbrt added a commit to chixiaowen/cosmos-sdk that referenced this issue Mar 1, 2023
julienrbrt added a commit to chixiaowen/cosmos-sdk that referenced this issue Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue T:tech debt Tech debt that should be cleaned up
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants