You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We updated ethermint to use GRPCClient(introduced here) to enjoy concurrency, but there's a query handler that return nil, nil under certain conditions, when that happens, it'll crash the whole node.
Currently, we fix that by returning a proper error, but since crashing the node could be a DoS vulnability, it'd be good that we eliminate that possibility.
the panic happens here, I guess the nil value is not caught by the previous check as the comment suggested.
Version
0.46
Steps to Reproduce
The text was updated successfully, but these errors were encountered:
yihuang
added a commit
to yihuang/cosmos-sdk
that referenced
this issue
Sep 21, 2022
Summary of Bug
We updated ethermint to use
GRPCClient
(introduced here) to enjoy concurrency, but there's a query handler thatreturn nil, nil
under certain conditions, when that happens, it'll crash the whole node.Currently, we fix that by returning a proper error, but since crashing the node could be a DoS vulnability, it'd be good that we eliminate that possibility.
the panic happens here, I guess the nil value is not caught by the previous check as the comment suggested.
Version
0.46
Steps to Reproduce
The text was updated successfully, but these errors were encountered: