Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Implement .IsLTE for types.Coin #11366

Closed
4 tasks
lxgr-linux opened this issue Mar 11, 2022 · 0 comments · Fixed by #11441
Closed
4 tasks

[Feature Request] Implement .IsLTE for types.Coin #11366

lxgr-linux opened this issue Mar 11, 2022 · 0 comments · Fixed by #11441

Comments

@lxgr-linux
Copy link

Summary

It would be to implement .IsLTE for types.Coin.

Problem Definition

types.Coin implements .IsLT, .IsGT and .IsGTE, which are the equivalents of <, >, >= for comparing two coins. But it does not implement .IsLTE the equivalent of <=. It would benefit the sdk by adding a new method to compare coins and adds more consistency, since .IsLT, .IsGT and .IsGTE are already there.

Proposal

It should return whether or the Coin the method is called on is less or equal to another Coin.
Takes a Coin and returns a bool

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@julienrbrt julienrbrt mentioned this issue Mar 23, 2022
Merged
19 tasks
@mergify mergify bot closed this as completed in #11441 Mar 24, 2022
mergify bot pushed a commit that referenced this issue Mar 24, 2022
@julienrbrt
feat: Implement .IsLTE for types.Coin (#11441)
5033758 
## Description

Closes: #11366

Implement `.IsLTE` for `types.Coin`.

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Implement .IsLTE for types.Coin
1 participant
@lxgr-linux