Add metadata to Vote in x/gov

[blushi]

Summary

Add metadata to Vote in x/gov (should use the existing maxMetadataLen constraint).

Remove metadata field from Vote in x/group

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[aaronc]

Why?

[blushi]

Why?

This was discussed during the last Gov / groups weekly sync with @cmwaters @hxrts @nooomski (notes) to align more with x/gov.

[aaronc]

I guess we can add back later but the idea is to be able to support voting interfaces like Loomio where a voter can provide and explanation

[amaury1093]

I guess we can add back later

Small note: Since it's in a Msg, I'm not sure it's easy to add later, unless we create a new Msg.

I don't have a strong opinion on add or not, but if we add, I would prefer:

• to align on both gov/group MsgVote
• to change bytes to string (same as gov: add metadata field to proposal #10490 (comment))

[aaronc]

Agree with change to string because of ledger signing UX. If we think there’s a use case for people describing their votes - which I actually think is good for governance - then we should have metadata for votes in both gov and group with a short character limit (maybe 128) long enough for a URL + hash

[hxrts]

We either needed to add to gov or remove from groups and it seemed easier to do the later. Also there was some state bloat concern.

[blushi]

FYI After our gov/group dev sync today, we aligned on adding metadata to Vote in x/gov instead, I've updated the issue description to account for that.