fix(baseapp): fix snapshot interval bug (backport #14049) (#14053)

cosmos · Nov 29, 2022 · 7bb7fa9 · 7bb7fa9
1 parent 9765823
commit 7bb7fa9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -41,13 +41,17 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 * (deps) Bump Tendermint version to [v0.34.24](https://github.com/tendermint/tendermint/releases/tag/v0.34.24).
 
+### Bug Fixes
+
+* (baseapp) [#14049](https://github.com/cosmos/cosmos-sdk/pull/14049) Fix state sync when interval is zero.
+
 ## [v0.46.6](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.46.6) - 2022-11-18
 
 ### Improvements
 
 * (config) [#13894](https://github.com/cosmos/cosmos-sdk/pull/13894) Support state streaming configuration in `app.toml` template and default configuration.
 
-## Bug Fixes
+### Bug Fixes
 
 * (x/gov) [#13918](https://github.com/cosmos/cosmos-sdk/pull/13918) Fix propagation of message errors when executing a proposal.
 

diff --git a/baseapp/options.go b/baseapp/options.go
@@ -218,7 +218,7 @@ func (app *BaseApp) SetSnapshot(snapshotStore *snapshots.Store, opts snapshottyp
 	if app.sealed {
 		panic("SetSnapshot() on sealed BaseApp")
 	}
-	if snapshotStore == nil || opts.Interval == snapshottypes.SnapshotIntervalOff {
+	if snapshotStore == nil {
 		app.snapshotManager = nil
 		return
 	}

diff --git a/snapshots/types/options.go b/snapshots/types/options.go
@@ -10,10 +10,6 @@ type SnapshotOptions struct {
 	KeepRecent uint32
 }
 
-// SnapshotIntervalOff represents the snapshot interval, at which
-// no snapshots are taken.
-const SnapshotIntervalOff uint64 = 0
-
 func NewSnapshotOptions(interval uint64, keepRecent uint32) SnapshotOptions {
 	return SnapshotOptions{
 		Interval:   interval,