Skip to content

Commit

Permalink
chore: fix x/mint param sims (#12461)
Browse files Browse the repository at this point in the history
`RandomizedParams` generates random parameter changes during simulations, however, it does so through `ParamChangeProposal` which is now legacy. 

Once all modules are migrated we will remove `RandomizedParams` entirely from the simulation interface.

For now, we just return an empty slice.
  • Loading branch information
alexanderbez committed Jul 5, 2022
1 parent ec0c809 commit 1dcf633
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
1 change: 0 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@ jobs:
**/**.go
go.mod
go.sum
if: env.GIT_DIFF
- name: test-sim-nondeterminism
run: |
make test-sim-nondeterminism
Expand Down
6 changes: 5 additions & 1 deletion x/mint/module.go
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,12 @@ func (AppModule) ProposalContents(simState module.SimulationState) []simtypes.We
}

// RandomizedParams creates randomized mint param changes for the simulator.
//
// TODO: Returns an empty slice which will make parameter changes a no-op during
// simulations. Once all modules are migrated, remove RandomizedParams from
// the simulation interface.
func (AppModule) RandomizedParams(r *rand.Rand) []simtypes.ParamChange {
return simulation.ParamChanges(r)
return []simtypes.ParamChange{}
}

// RegisterStoreDecoder registers a decoder for mint module's types.
Expand Down

0 comments on commit 1dcf633

Please sign in to comment.