Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conservative bloomfilter #42

Merged
merged 19 commits into from
Nov 13, 2022
Merged

Conservative bloomfilter #42

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
87948b9
goleveldb bloom filter
tac0turtle Aug 15, 2022
09bf65d
Merge branch 'main' into marko/goleveldb
tac0turtle Aug 18, 2022
cd07c5e
Merge branch 'main' into marko/goleveldb
faddat Aug 22, 2022
bdfdbe7
update marko's branch
faddat Aug 22, 2022
e3cc080
bloom filter
faddat Aug 22, 2022
892d6c3
Update settings.json
faddat Aug 22, 2022
af9eae0
Update goleveldb.go
faddat Aug 22, 2022
c0919a7
Merge branch 'main' into conservative-bloomfilter
faddat Aug 26, 2022
8c61198
Merge branch 'main' into conservative-bloomfilter
faddat Aug 31, 2022
cdfd021
Update goleveldb.go
faddat Aug 31, 2022
9b32c5a
remove all changes to goleveldb config except for the bloom filter
faddat Sep 1, 2022
37c2da2
fumpt
faddat Sep 1, 2022
da65a80
Update .gitpod.yml
faddat Sep 1, 2022
faad9ab
some files were changed that shouldn't be
faddat Sep 1, 2022
781811d
restore .vscode
faddat Sep 1, 2022
c535423
update changelog
faddat Sep 1, 2022
4af2b3f
Merge branch 'main' into conservative-bloomfilter
faddat Sep 15, 2022
eb42e0e
gofumpt
faddat Sep 15, 2022
fc6faf1
Merge branch 'main' into conservative-bloomfilter
tac0turtle Nov 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# CODEOWNERS: https://help.github.com/articles/about-codeowners/

* @alexanderbez @cmwaters @marbar3778 @tychoish @williambanfield
* @alexanderbez @marbar3778
2 changes: 1 addition & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
"go.lintTool": "golangci-lint",
"go.lintOnSave": "workspace",
"go.formatTool": "gofumpt"
}
}
9 changes: 8 additions & 1 deletion goleveldb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (

"github.com/syndtr/goleveldb/leveldb"
"github.com/syndtr/goleveldb/leveldb/errors"
"github.com/syndtr/goleveldb/leveldb/filter"
"github.com/syndtr/goleveldb/leveldb/opt"
"github.com/syndtr/goleveldb/leveldb/util"
)
Expand All @@ -24,7 +25,13 @@ type GoLevelDB struct {
var _ DB = (*GoLevelDB)(nil)

func NewGoLevelDB(name string, dir string) (*GoLevelDB, error) {
return NewGoLevelDBWithOpts(name, dir, nil)
options := &opt.Options{
Filter: filter.NewBloomFilter(10),
OpenFilesCacheCapacity: 8192,
BlockCacheCapacity: opt.GiB,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the default here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

200 on mac, 500 on other.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add comments to say what the normal default was.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolutely.

Sorry for delay on this, been real busy.

WriteBuffer: 64 * opt.MiB,
}
return NewGoLevelDBWithOpts(name, dir, options)
}

func NewGoLevelDBWithOpts(name string, dir string, o *opt.Options) (*GoLevelDB, error) {
Expand Down