Let /auth/accounts/<address> client support 0.37-0.39 format #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 25, 2020
Merged
ethanfrey
approved these changes
Jul 27, 2020
willclarktech
approved these changes
Jul 28, 2020
packages/sdk38/src/lcdapi/auth.ts
Outdated
| /** | ||
| * A Cosmos SDK base account. | ||
| * | ||
| * This type described the base account representation as returned |
packages/sdk38/src/lcdapi/auth.ts
Outdated
| * The public key of the account. This is not available on-chain as long as the account | ||
| * did not send a transaction. | ||
| * | ||
| * This was a type/value object in Cosmos SDK 0.37, changed to bach32 in Cosmos SDK 0.38 ([1]) |
packages/sdk38/src/lcdapi/utils.ts
Outdated
| import { PubKey } from "../types"; | ||
|
|
||
| /** | ||
| * Convers an integer expressed as number or string to a number. |
packages/sdk38/src/lcdapi/utils.ts
Outdated
| } | ||
|
|
||
| /** | ||
| * Convers an integer expressed as number or string to a number. |
webmaster128
force-pushed
the
uint64ToNumber-and-String
branch
from
2bd8479
to
5ad11bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #313.
This allows us to use one LCD API client for Comsos SDK 0.37-0.39.
Closes #302
Closes #312