Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing earliest block in RPC sync info #1448

Closed
livthomas opened this issue Jun 29, 2023 · 3 comments
Closed

Missing earliest block in RPC sync info #1448

livthomas opened this issue Jun 29, 2023 · 3 comments

Comments

@livthomas
Copy link
Contributor

Cosmjs only parses the following fields from sync_info record returned by /status RPC method:

  • catching_up
  • latest_app_hash
  • latest_block_hash
  • latest_block_height
  • latest_block_time

But there are also other fields present in sync_info which are not processed by cosmjs:

  • earliest_app_hash
  • earliest_block_hash
  • earliest_block_height
  • earliest_block_time

Steps to Reproduce

  1. Try to hit /status endpoint on any public RPC node (e.g. https://cosmos-rpc.rockrpc.net/status).
  2. See what fields are returned within result.sync_info.
  3. Look at RpcSyncInfo interface in both tendermint34 and tendermint37 adaptors.
@webmaster128
Copy link
Member

Thank you for bringing this up. Sounds like a straight forwards addition to the tendermint-rpc packet. Do you want to work on a PR for that?

@livthomas
Copy link
Contributor Author

Yes, I'm already working on it.

livthomas added a commit to rockawayx-labs/cosmjs that referenced this issue Jun 29, 2023
livthomas added a commit to rockawayx-labs/cosmjs that referenced this issue Jun 29, 2023
livthomas added a commit to rockawayx-labs/cosmjs that referenced this issue Jun 30, 2023
livthomas added a commit to rockawayx-labs/cosmjs that referenced this issue Jun 30, 2023
livthomas added a commit to rockawayx-labs/cosmjs that referenced this issue Jun 30, 2023
livthomas added a commit to rockawayx-labs/cosmjs that referenced this issue Jul 10, 2023
livthomas added a commit to rockawayx-labs/cosmjs that referenced this issue Jul 10, 2023
@webmaster128
Copy link
Member

Done in #1449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants