Skip to content

Change the visibility of functions in the data types #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Change the visibility of functions in the data types #743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99cfcec
Update Dropdown.php
hfr Jul 15, 2025
6721b46
Update Checkbox.php
hfr Jul 15, 2025
18bbae5
Update Lookup.php
hfr Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/Checkbox.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class Checkbox extends AbstractBaseType
*
* @return array
*/
protected function getOptions()
public function getOptions()
{
$options = explode(',', $this->config['values']);
$options = array_map('trim', $options);
Expand Down
2 changes: 1 addition & 1 deletion types/Dropdown.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class Dropdown extends AbstractBaseType
*
* @return array
*/
protected function getOptions()
public function getOptions()
{
$options = explode(',', $this->config['values']);
$options = array_map('trim', $options);
Expand Down
6 changes: 3 additions & 3 deletions types/Lookup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public function __construct($config = null, $label = '', $ismulti = false, $tid
*
* @return Column|false
*/
protected function getLookupColumn()
public function getLookupColumn()
{
if ($this->column instanceof Column) return $this->column;
$this->column = $this->getColumn($this->config['schema'], $this->config['field']);
Expand All @@ -58,7 +58,7 @@ protected function getLookupColumn()
* @param string $infield
* @return Column|false
*/
protected function getColumn($table, $infield)
public function getColumn($table, $infield)
{
global $conf;

Expand Down Expand Up @@ -116,7 +116,7 @@ protected function getColumn($table, $infield)
*
* @return array
*/
protected function getOptions()
public function getOptions()
{
$schema = $this->config['schema'];
$column = $this->getLookupColumn();
Expand Down