improve multiline

cosmastech · Dec 30, 2024 · 4c9294c · 4c9294c
1 parent d77c516
commit 4c9294c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/cli/prompt_secret.ts b/cli/prompt_secret.ts
@@ -59,15 +59,17 @@ export function promptSecret(
   const callback = !mask ? undefined : (n: number) => {
     let line = `${message}${mask.repeat(n)}`;
 
-    let charsPastLineLength = line.length % columns;
+    const charsPastLineLength = line.length % columns;
 
     if (line.length > columns) {
-      if (charsPastLineLength === 0) {
-        charsPastLineLength = columns;
-      }
-      line = line.slice(-1 * charsPastLineLength);
+      line = line.slice(
+        -1 * (charsPastLineLength === 0 ? columns : charsPastLineLength),
+      );
+    }
+    // Always jump the cursor back to the beginning of the line unless it's the first character.
+    if (charsPastLineLength !== 1) {
+      output.writeSync(CLR);
     }
-    output.writeSync(CLR);
     output.writeSync(encoder.encode(line));
   };
 

diff --git a/cli/prompt_secret_test.ts b/cli/prompt_secret_test.ts
@@ -572,7 +572,6 @@ Deno.test("promptSecret() wraps characters wider than console columns", () => {
     "? **",
     "\r\x1b[K",
     "? ***",
-    "\r\x1b[K",
     "*",
     "\r\x1b[K",
     "**",
@@ -582,7 +581,6 @@ Deno.test("promptSecret() wraps characters wider than console columns", () => {
     "****",
     "\r\x1b[K",
     "*****",
-    "\r\x1b[K",
     "*",
     "\r\x1b[K",
     "**",