Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #263 - Update the npm package metadata #264

Merged
merged 1 commit into from
Nov 9, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 23 additions & 17 deletions source/js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,15 @@
"name": "astronomy-engine",
"version": "2.1.8",
"description": "Astronomy calculation for Sun, Moon, and planets.",
"main": "./astronomy.js",
"module": "./esm/astronomy.js",
"typings": "./astronomy.d.ts",
"files": [
"esm/astronomy.js",
"astronomy.d.ts",
"astronomy.js",
"astronomy.min.js",
"astronomy.browser.js",
"astronomy.browser.min.js"
],
"author": "Donald Cross",
"license": "MIT",
"homepage": "https://github.com/cosinekitty/astronomy#readme",
"repository": {
"type": "git",
"url": "git+https://github.com/cosinekitty/astronomy.git"
"url": "https://github.com/cosinekitty/astronomy"
},
"bugs": {
"url": "https://github.com/cosinekitty/astronomy/issues"
},
"keywords": [
"astronomy",
Expand All @@ -32,11 +27,22 @@
"constellation",
"orbit"
],
"author": "Donald Cross",
"license": "MIT",
"bugs": {
"url": "https://github.com/cosinekitty/astronomy/issues"
"files": [
"esm/astronomy.js",
"astronomy.d.ts",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matheo (I'm asking this because I don't know much about npm packages.) Should we also include astronomy.ts in this list? Do people ever develop against TypeScript source directly within an npm package?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, ESM is already close to the ts syntax
and npmJS is not supposed to have TS packages 😅

"astronomy.js",
"astronomy.min.js",
"astronomy.browser.js",
"astronomy.browser.min.js"
],
"exports": {
".": {
"require": "./astronomy.js",
"import": "./esm/astronomy.js"
}
},
"homepage": "https://github.com/cosinekitty/astronomy#readme",
"main": "./astronomy.js",
"module": "./esm/astronomy.js",
"types": "./astronomy.d.ts",
"sideEffects": false
}