credo

coryodaniel · Feb 20, 2022 · 652abfa · 652abfa
1 parent 4867a41
commit 652abfa
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/k8s/sys/open_telemetry.ex b/lib/k8s/sys/open_telemetry.ex
@@ -1,7 +1,11 @@
 defmodule K8s.Sys.OpenTelemetry do
   @moduledoc "Converts telemetry spans to opentelemetry tracing spans"
+
+  @doc """
+  Attaches telemetry spans to the opentelemetry processor
+  """
   @spec attach() :: :ok
-  def attach() do
+  def attach do
     for span <- K8s.Sys.Telemetry.spans() do
       span_name = Enum.join(span, ".")
 

diff --git a/lib/k8s/sys/spandex.ex b/lib/k8s/sys/spandex.ex
@@ -11,6 +11,9 @@ defmodule K8s.Sys.Spandex do
 
   require Spandex
 
+  @doc """
+  Attaches telemetry spans to the spandex processor
+  """
   @spec attach(atom()) :: :ok
   def attach(tracer) do
     for span <- K8s.Sys.Telemetry.spans() do
@@ -68,7 +71,7 @@ defmodule K8s.Sys.Spandex do
         %{type: :stop, tracer: tracer}
       ) do
     tracer.update_span(tags: Map.to_list(metadata))
-    tracer.finish_span() |> IO.inspect()
+    tracer.finish_span()
     :ok
   end