Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add record values formatter on records patch #1898

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

KinyaElGrande
Copy link
Contributor

Add record values formatter on records patch to fix time-only inline edit.

@KinyaElGrande KinyaElGrande requested a review from tjerman August 29, 2024 15:23
Copy link
Member

@tjerman tjerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but format the code

@KinyaElGrande KinyaElGrande force-pushed the 2023.9.x-fix-date-time-inline-edit branch 4 times, most recently from e5527b8 to 40d8212 Compare August 30, 2024 08:10
@KinyaElGrande
Copy link
Contributor Author

I wasn’t sure why there was a formatting inconsistency, it looked fine in GoLand.
Fixed it using VSCode’s Go formatter.

@katrinDY
Copy link
Contributor

LGTM. Awesome job :)

@KinyaElGrande KinyaElGrande force-pushed the 2023.9.x-fix-date-time-inline-edit branch from 40d8212 to 780f6d0 Compare August 30, 2024 10:26
@KinyaElGrande KinyaElGrande force-pushed the 2023.9.x-fix-date-time-inline-edit branch from 780f6d0 to 55e8ea9 Compare August 30, 2024 10:28
@KinyaElGrande KinyaElGrande merged commit fcc5a75 into 2023.9.x Aug 30, 2024
11 checks passed
@KinyaElGrande KinyaElGrande deleted the 2023.9.x-fix-date-time-inline-edit branch August 30, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants