2023.9.x feature clone report #1805
Conversation
| @@ -28,28 +28,26 @@ | |||
| size="lg" | |||
| size-confirm="lg" | |||
| variant="danger" | |||
| :disabled="deleteDisabled || processingDelete || processing" | |||
There was a problem hiding this comment.
You need to keep the processing otherwise the other buttons are clickable when saving is processing.
| size="lg" | ||
| variant="light" | ||
| :disabled="processing" | ||
| :disabled="cloneDisabled || processingClone" | ||
| :processing="processingClone" |
There was a problem hiding this comment.
The button variant should match the other clone buttons in the system
| @@ -95,14 +97,12 @@ export default { | |||
| handleClone (report) { | |||
| this.processing = true | |||
| this.processingClone = true | |||
| const { handle, meta, sources, blocks, scenarios, labels } = report | |||
| const clonedReport = this.report.clone() | |||
There was a problem hiding this comment.
There is no need to clone the report (this causes the list clone to fail)
Just prepare the variables which you get from the report and pass them to the reportCreate
| meta.name = `${meta.name} (${this.$t('general:cloneSuffix')})` | ||
| const handle = reportHandle ? `${report.handle}_${this.$t('general:cloneSuffix')}` : '' |
There was a problem hiding this comment.
I know i said to add the clone to the handle, but it just occurred to me that could raise an error if you clone the same report twice (they'll both have same handle)
So its honestly better to not have a handle at all.
EmmyMay
force-pushed
the
2023.9.x-feature-clone-report
branch
4 times, most recently
from
9c4fada to
76d2377
Compare
|
EmmyMay
force-pushed
the
2023.9.x-feature-clone-report
branch
2 times, most recently
from
052d3e3 to
7dedd83
Compare
EmmyMay
force-pushed
the
2023.9.x-feature-clone-report
branch
from
7dedd83 to
8a78320
Compare
EmmyMay
force-pushed
the
2023.9.x-feature-clone-report
branch
from
8a78320 to
0ac8bde
Compare
The following changes are implemented
TODO: Summary
Changes in the user interface:
TODO: Add screenshots, recordings or remove this section
Checklist when submitting a final (!draft) PR