Send ddb region as awsCfg #5842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com>
Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com>
yeya24
reviewed
Mar 29, 2024
| @@ -57,13 +57,12 @@ func newDynamodbKV(cfg Config, logger log.Logger) (dynamodbKV, error) { | |||
| return dynamodbKV{}, err | |||
| } | |||
|
|
|||
| awsCfg := aws.NewConfig() | |||
| if len(cfg.Region) > 0 { | |||
There was a problem hiding this comment.
Is this check still necessary?
There was a problem hiding this comment.
Region here is optional in the config.
I would need to do a test to see what the client will do if we send an empty string. I am not sure if it will try to use the env var.
yeya24
approved these changes
Mar 29, 2024
alanprot
pushed a commit
to alanprot/cortex
that referenced
this pull request
Apr 2, 2024
* Send ddb region as awsCfg Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com> * Add changelog Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com> * Fix lint Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com> --------- Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Send DynamoDB region as awsConfig instead of session config
Which issue(s) this PR fixes:
Fixes #5840
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]