Update cache on CAS for DDB #5838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com>
Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com>
danielblando
force-pushed
the
updateCacheOnCas
branch
from
bb29004
to
4a6f500
Compare
yeya24
reviewed
Mar 28, 2024
Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com>
danielblando
force-pushed
the
updateCacheOnCas
branch
from
fa0fb05
to
ed63d7b
Compare
yeya24
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
We are now also updating the staleData on CAS operation.
The CAS operation is mostly used via lifecycle and did not had any data before. This change start to also have stale data on lifecycle. This is mainly important because the ring of a lifecycle is used by distributor to check local limits.
Which issue(s) this PR fixes:
When using DDB and having unhealthy distributors on the ring, the healthInstancesCount on the ring was calculated wrong because the staleData was not set and by that the timestamp from the last update was empty making the heartbeat of pods be always healthy. This introduce stale data to lifecycle which is used to check for local limits.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]