add context cancellation checks on GetSeries #5827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlan-z
force-pushed
the
context-cancellation-checks
branch
from
d36daa5
to
5218578
Compare
alanprot
reviewed
Mar 22, 2024
erlan-z
force-pushed
the
context-cancellation-checks
branch
from
5218578
to
f8d0d61
Compare
erlan-z
force-pushed
the
context-cancellation-checks
branch
2 times, most recently
from
c4e20c6
to
9bd12de
Compare
alanprot
reviewed
Mar 26, 2024
alanprot
reviewed
Mar 26, 2024
pkg/querier/querier.go
Outdated
Comment on lines
568
to
570
| if ctx.Err() != nil { | ||
| return storage.ErrSeriesSet(ctx.Err()) | ||
| } |
There was a problem hiding this comment.
I think we did something similar and thanos and the perf was ok, right @yeya24 ?
There was a problem hiding this comment.
We have something like this when expanding postings. No obvious impact.
yeya24
reviewed
Mar 26, 2024
pkg/querier/querier.go
Outdated
Comment on lines
568
to
570
| if ctx.Err() != nil { | ||
| return storage.ErrSeriesSet(ctx.Err()) | ||
| } |
There was a problem hiding this comment.
We have something like this when expanding postings. No obvious impact.
erlan-z
force-pushed
the
context-cancellation-checks
branch
2 times, most recently
from
78a8848
to
8328536
Compare
alanprot
approved these changes
Mar 27, 2024
Signed-off-by: Erlan Zholdubai uulu <erlanz@amazon.com>
erlan-z
force-pushed
the
context-cancellation-checks
branch
from
8328536
to
74d2af2
Compare
Signed-off-by: Erlan Zholdubai uulu <erlanz@amazon.com>
|
@erlan-z Can you update changelog please? |
Signed-off-by: Erlan Zholdubai uulu <erlanz@amazon.com>
erlan-z
force-pushed
the
context-cancellation-checks
branch
from
b730522
to
bf18092
Compare
|
I feel we might also miss some context check at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add some context cancellation checks on GetSeries
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]