add query storage wall time to query stats #5799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
force-pushed
the
storage-wall-time
branch
2 times, most recently
from
72c43cd
to
4fbf05d
Compare
yeya24
force-pushed
the
storage-wall-time
branch
2 times, most recently
from
a53a58c
to
356b646
Compare
yeya24
changed the title
Signed-off-by: Ben Ye <benye@amazon.com>
yeya24
force-pushed
the
storage-wall-time
branch
from
c16e44e
to
9817bae
Compare
alanprot
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
There is a
querier_wall_timefield in query stats log, meaning total time spent on querier to execute the query. This includes the time to fetch from underlying storage and execute the query using the query engine.The query itself can be either very simple or very complex and the evaluation might be even slower than fetching data from storage itself.In order to identify how the long the querier spends fetching data from storage layer, additional log field is required. This pr adds a field called
query_storage_wall_timefor this requirement.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]