Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the reflect package to an unsafe package #5775

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

yj-yoo
Copy link
Contributor

@yj-yoo yj-yoo commented Feb 19, 2024

What this PR does:
as 'reflect.StringHeader' is deprecated, it is replaced with an unsafe package.

Which issue(s) this PR fixes:
Fixes #5774

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Youngjun <yj.yoo@okestro.com>
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks!

@yeya24 yeya24 merged commit c2eb4e7 into cortexproject:master Mar 30, 2024
16 checks passed
alanprot pushed a commit to alanprot/cortex that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replacing reprecated functions
2 participants