Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compactor start duration in seconds metric #5683

Merged

Conversation

alexqyle
Copy link
Contributor

What this PR does:
Add additional metrics to record compactor start and stop duration in seconds. These metrics would be helpful to keep track of abnormally long start or stop time of compactor.

Which issue(s) this PR fixes:
NA

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

… seconds

Signed-off-by: Alex Le <leqiyue@amazon.com>
Signed-off-by: Alex Le <leqiyue@amazon.com>
@alexqyle alexqyle changed the title Add additional metrics to record compactor start and stop duration in seconds Add compactor start and stop duration in seconds metrics Nov 28, 2023
pkg/compactor/compactor.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Alex Le <leqiyue@amazon.com>
Signed-off-by: Alex Le <leqiyue@amazon.com>
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 29, 2023
Signed-off-by: Alex Le <leqiyue@amazon.com>
@alexqyle alexqyle changed the title Add compactor start and stop duration in seconds metrics Add compactor start duration in seconds metric Nov 30, 2023
@yeya24 yeya24 merged commit ba730c9 into cortexproject:master Nov 30, 2023
14 checks passed
@alexqyle alexqyle deleted the compactor-start-stop-time-metric branch July 17, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants