Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query priority #5605

Merged
merged 49 commits into from
Nov 30, 2023
Merged

Query priority #5605

merged 49 commits into from
Nov 30, 2023

Commits on Nov 28, 2023

  1. Separate user queue channel into two - normalQueue and highPriorityQueue 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    52d520b View commit details
    Browse the repository at this point in the history

  2. Add ReservedHighPriorityQueriers 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    646853a View commit details
    Browse the repository at this point in the history

  3. Change default priority for all requests to low 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    39639c4 View commit details
    Browse the repository at this point in the history

  4. Update config description 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    38945ac View commit details
    Browse the repository at this point in the history

  5. Lint 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    d0f7e74 View commit details
    Browse the repository at this point in the history

  6. Fix test 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    fec4a90 View commit details
    Browse the repository at this point in the history

  7. More test fix 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    ad046d0 View commit details
    Browse the repository at this point in the history

  8. Add HighPriorityQueries confing + placeholder for IsHighPriorityQuery… 

    … func

Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    a88ad90 View commit details
    Browse the repository at this point in the history

  9. Nit 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    b050ac1 View commit details
    Browse the repository at this point in the history

  10. Lint 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    f767614 View commit details
    Browse the repository at this point in the history

  11. Implement IsPriorityQuery 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    de06e37 View commit details
    Browse the repository at this point in the history

  12. Add changelog 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    8b31b1c View commit details
    Browse the repository at this point in the history

  13. Pass timestamp as param 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    d28aa33 View commit details
    Browse the repository at this point in the history

  14. Parse form so that range query parameters are passed to the roundtrip 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    daf269b View commit details
    Browse the repository at this point in the history

  15. Address comments 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    3b603ba View commit details
    Browse the repository at this point in the history

  16. Add CompiledRegex to HighPriorityQuery 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    393d9f0 View commit details
    Browse the repository at this point in the history

  17. Introduce numbered priority + change config structure 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    ebc2c1e View commit details
    Browse the repository at this point in the history

  18. Lint 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    07723ce View commit details
    Browse the repository at this point in the history

  19. Updated docs 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    488921c View commit details
    Browse the repository at this point in the history

  20. Skip regex compile if it is match all 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    d8b9799 View commit details
    Browse the repository at this point in the history

  21. Updated GetPriority to handle new config structure 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    e6b9348 View commit details
    Browse the repository at this point in the history

  22. Add priority queue to user queue 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    5eb2d73 View commit details
    Browse the repository at this point in the history

  23. Nits + priority queue test added 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    f064b3a View commit details
    Browse the repository at this point in the history

  24. Create user request queue test 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    e41e4c1 View commit details
    Browse the repository at this point in the history

  25. Add reserved querier logic 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    ca2cd1c View commit details
    Browse the repository at this point in the history

  26. Fix tests 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    067cc83 View commit details
    Browse the repository at this point in the history

  27. Add priority label to request and queue metrics 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    e1b996f View commit details
    Browse the repository at this point in the history

  28. Fix tests 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    2f7947c View commit details
    Browse the repository at this point in the history

  29. Fix tests 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    f9df453 View commit details
    Browse the repository at this point in the history

  30. Refactor 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    a510f77 View commit details
    Browse the repository at this point in the history

  31. Add more tests 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    717d746 View commit details
    Browse the repository at this point in the history

  32. Lint 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    f3a9772 View commit details
    Browse the repository at this point in the history

  33. Update doc 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    87c9a0e View commit details
    Browse the repository at this point in the history

  34. Improve time comparison when assigning priority 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    506d5c2 View commit details
    Browse the repository at this point in the history

  35. Make reserved querier to match exact priority + change query length g… 

    …auge vector in user request queue

Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    c0f268d View commit details
    Browse the repository at this point in the history

  36. Bug fix 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    0b98773 View commit details
    Browse the repository at this point in the history

  37. Add comments 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    3fffc3f View commit details
    Browse the repository at this point in the history

  38. Address comments 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    2abeffb View commit details
    Browse the repository at this point in the history

  39. Make reserved querier to handle priorities higher or equal 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    ab4b9c7 View commit details
    Browse the repository at this point in the history

  40. Add benchmark tests 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    8086aee View commit details
    Browse the repository at this point in the history

  41. Update regex to be compiled upon unmarshal 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    584c6f9 View commit details
    Browse the repository at this point in the history

  42. Make start and end time check to be skipped if not specified 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    4001fe4 View commit details
    Browse the repository at this point in the history

  43. Assign priority before splitting the query 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    aa38a8c View commit details
    Browse the repository at this point in the history

  44. Attempt to fix tests 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    6c1813b View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Address comments 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    cdd2a0c View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Minor improvements 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    3f347e4 View commit details
    Browse the repository at this point in the history

  2. Rename query start end time 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    3ee0b0d View commit details
    Browse the repository at this point in the history

  3. Improve tests 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    c0252f1 View commit details
    Browse the repository at this point in the history

  4. Nit 

    Signed-off-by: Justin Jung <jungjust@amazon.com>
    @justinjung04
    justinjung04 committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    b6eb74d View commit details
    Browse the repository at this point in the history