Added S3 SSE support to alertmanager storage #3906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
reviewed
Mar 4, 2021
There was a problem hiding this comment.
I think we should step back, and split split the two functions of existing user bucket (prefixing, and injecting SSE) to separate wrappers, and only use SSE-injection here.
Prefixed bucket client should not require any change in this PR.
New sse-injecting bucket client would only inject SSE based on configured user.
UserBucketClient would combine the two together. It would be used elsewhere, while Alertmanager would only use "sse-injecting" client. WDYT?
3 tasks
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
add-s3-sse-support-to-alertmanager
branch
from
6b53af5
to
9017fe9
Compare
@pstibrany Good idea. Done. |
roystchiang
pushed a commit
to roystchiang/cortex
that referenced
this pull request
Apr 6, 2022
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
After preliminary refactoring PRs, we can finally add S3 SSE support to alertmanager with per-tenant key support.
Due to the special nature of the objects structure used by
AlertStore(the user ID is not a prefix but the object, so the alertmanager config for user-1 is stored in the objectalerts/user-1) I had to some refactoring inUserBucketClientandPrefixedBucketClient.I've manually tested it with S3 + KMS and looks working fine.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]