update docs

Signed-off-by: Ben Ye <benye@amazon.com>
cortexproject · Nov 30, 2023 · 6b09fb2 · 6b09fb2
1 parent 209d5b6
commit 6b09fb2
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@
 * [CHANGE] Index Cache: Multi level cache backfilling operation becomes async. Added `-blocks-storage.bucket-store.index-cache.multilevel.max-async-concurrency` and `-blocks-storage.bucket-store.index-cache.multilevel.max-async-buffer-size` configs and metric `cortex_store_multilevel_index_cache_backfill_dropped_items_total` for number of dropped items. #5661
 * [FEATURE] Ingester: Add per-tenant new metric `cortex_ingester_tsdb_data_replay_duration_seconds`. #5477
 * [ENHANCEMENT] Store Gateway: Added `-store-gateway.enabled-tenants` and `-store-gateway.disabled-tenants` to explicitly enable or disable store-gateway for specific tenants. #5638
+* [ENHANCEMENT] Index Cache: Multi level cache adds config `max_backfill_items` to cap max items to backfill per async operation. #5686
 
 ## 1.16.0 2023-11-20
 

diff --git a/docs/blocks-storage/querier.md b/docs/blocks-storage/querier.md
@@ -719,6 +719,10 @@ blocks_storage:
         # CLI flag: -blocks-storage.bucket-store.index-cache.multilevel.max-async-buffer-size
         [max_async_buffer_size: <int> | default = 10000]
 
+        # The maximum number of items to backfill per asynchronous operation.
+        # CLI flag: -blocks-storage.bucket-store.index-cache.multilevel.max-backfill-items
+        [max_backfill_items: <int> | default = 10000]
+
     chunks_cache:
       # Backend for chunks cache, if not empty. Supported values: memcached.
       # CLI flag: -blocks-storage.bucket-store.chunks-cache.backend

diff --git a/docs/blocks-storage/store-gateway.md b/docs/blocks-storage/store-gateway.md
@@ -834,6 +834,10 @@ blocks_storage:
         # CLI flag: -blocks-storage.bucket-store.index-cache.multilevel.max-async-buffer-size
         [max_async_buffer_size: <int> | default = 10000]
 
+        # The maximum number of items to backfill per asynchronous operation.
+        # CLI flag: -blocks-storage.bucket-store.index-cache.multilevel.max-backfill-items
+        [max_backfill_items: <int> | default = 10000]
+
     chunks_cache:
       # Backend for chunks cache, if not empty. Supported values: memcached.
       # CLI flag: -blocks-storage.bucket-store.chunks-cache.backend

diff --git a/docs/configuration/config-file-reference.md b/docs/configuration/config-file-reference.md
@@ -1268,6 +1268,10 @@ bucket_store:
       # CLI flag: -blocks-storage.bucket-store.index-cache.multilevel.max-async-buffer-size
       [max_async_buffer_size: <int> | default = 10000]
 
+      # The maximum number of items to backfill per asynchronous operation.
+      # CLI flag: -blocks-storage.bucket-store.index-cache.multilevel.max-backfill-items
+      [max_backfill_items: <int> | default = 10000]
+
   chunks_cache:
     # Backend for chunks cache, if not empty. Supported values: memcached.
     # CLI flag: -blocks-storage.bucket-store.chunks-cache.backend

diff --git a/pkg/storage/tsdb/multilevel_cache.go b/pkg/storage/tsdb/multilevel_cache.go
@@ -3,7 +3,6 @@ package tsdb
 import (
 	"context"
 	"errors"
-	"slices"
 	"sync"
 
 	"github.com/oklog/ulid"
@@ -13,6 +12,7 @@ import (
 	"github.com/prometheus/prometheus/storage"
 	"github.com/thanos-io/thanos/pkg/cacheutil"
 	storecache "github.com/thanos-io/thanos/pkg/store/cache"
+	"golang.org/x/exp/slices"
 )
 
 const (