Skip to content

Add additional information about request handlers #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2019
Merged

Add additional information about request handlers #479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
364a5c6
Add additional information about request handlers
vishalbollu Sep 19, 2019
2ae1296
Reword info messages
vishalbollu Sep 19, 2019
4741bfa
Merge branch 'master' into inform-request-handler-registration
vishalbollu Sep 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions pkg/workloads/cortex/onnx_serve/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,21 @@ def start(args):
local_cache["request_handler"] = ctx.get_request_handler_impl(
api["name"], args.project_dir
)
request_handler = local_cache.get("request_handler")

if request_handler is not None and util.has_function(request_handler, "pre_inference"):
logger.info(
"using pre_inference request handler provided in {}".format(api["request_handler"])
)
else:
logger.info("pre_inference request handler not found")

if request_handler is not None and util.has_function(request_handler, "post_inference"):
logger.info(
"using post_inference request handler provided in {}".format(api["request_handler"])
)
else:
logger.info("post_inference request handler not found")

sess = rt.InferenceSession(model_path)
local_cache["sess"] = sess
Expand Down
16 changes: 16 additions & 0 deletions pkg/workloads/cortex/tf_api/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,22 @@ def start(args):
local_cache["request_handler"] = ctx.get_request_handler_impl(
api["name"], args.project_dir
)
request_handler = local_cache.get("request_handler")

if request_handler is not None and util.has_function(request_handler, "pre_inference"):
logger.info(
"using pre_inference request handler provided in {}".format(api["request_handler"])
)
else:
logger.info("pre_inference request handler not found")

if request_handler is not None and util.has_function(request_handler, "post_inference"):
logger.info(
"using post_inference request handler provided in {}".format(api["request_handler"])
)
else:
logger.info("post_inference request handler not found")

except Exception as e:
logger.exception("failed to start api")
sys.exit(1)
Expand Down