Skip to content

Merge kubectl logs #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 11, 2019
Merged

Merge kubectl logs #227

merged 6 commits into from
Jul 11, 2019

Conversation

vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Jul 10, 2019 •
edited by deliahu
Loading

Closes #214 , #216

Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart operator, and run cx refresh)\
  • Update examples
  • Update documentation (add any new files to summary.md)
  • Merge to master
  • Cherry-pick into release branches if it's a bugfix
  • Check gitbook that docs look good and links function properly
  • Alert team if dev environment changed
  • Delete the branch once it's merged

@vishalbollu vishalbollu requested review from 1vn and deliahu July 10, 2019 21:59
deliahu
deliahu reviewed Jul 11, 2019
View reviewed changes
deliahu
deliahu reviewed Jul 11, 2019
View reviewed changes
deliahu
deliahu reviewed Jul 11, 2019
View reviewed changes
@deliahu deliahu merged commit c8ee7fd into master Jul 11, 2019
@deliahu deliahu deleted the merge-kubectl-logs branch July 11, 2019 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

@1vn 1vn Awaiting requested review from 1vn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge logs from multiple API replicas
2 participants
@vishalbollu @deliahu