-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow additional kwargs to pass from reproject_match() -> reproject() #436
Allow additional kwargs to pass from reproject_match() -> reproject() #436
Conversation
bb7b381
to
cf61e44
Compare
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 13 13
Lines 1530 1530
=======================================
Hits 1470 1470
Misses 60 60
Continue to review full report at Codecov.
|
This makes sense to me, thanks 👍 . Mind adding a simple test to ensure that the |
@snowman2 how do you create these fixture files? When trying to re-use the same parameterized fixtures I keep getting this while trying to open mine:
After verifying in my debugger the file looked correct I just dumped it out to the fixture location with a It has the single data variable!
|
cf61e44
to
cf370e7
Compare
I squashed and committed what I have but will need help with that fixture. Thanks! |
I am thinking you need to create the netCDF file starting from a DataArray instead of from a Dataset. Are you able to do that? |
I tried that as well, I gave it the ol:
And |
What happens if you add |
cf370e7
to
bf8818f
Compare
That did it! It's odd that it was required there for some reason... |
bf8818f
to
2cd14e8
Compare
Related to #287 |
Thanks @four43 👍 |
Thanks for the review and help @snowman2. We appreciate the project :D |
I wanted to set a specific
nodata
value when running areproject_match
and I figured this was the most flexible. What do you all think?docs/history.rst
for all changes anddocs/rioxarray.rst
for new API