Breaking: Change imported library names to match Rust 1.79 #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
line 71 does the same thing.
jschwe
force-pushed
the
target_name_underscore
branch
2 times, most recently
from
8aa130f
to
e2d7c04
Compare
Store the package name of the rust target as a property, so that the user does not need to specify it. If I'm not missing anything, then this should also allow us to remove the `CARGO_PACKAGE` parameter completely (in a future update).
jschwe
force-pushed
the
target_name_underscore
branch
from
e2d7c04
to
11e27cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #501 cargo metadata will convert dashes in implicit library names to underscores starting with Rust 1.79 (now in beta).
To make the imported CMake target name consistent across Rust versions, corrosion will now also do the same conversion.