Corrosion tests should not test C++ features not used by Corrosion it… #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…self. This PR follows discussion for #183. * Problem addressed with this PR: - CMakeLists.txt uses std_cxx_17 to compile it's test cases. - Tests cases need std_cxx_17, because of their use of <string_view>. Because of both, Corrosion fails to compile on 'old' systems (I did not say vintage :-)). * Investigations: As Corrosion does not use <string_view>, it's not needed to use this in its test cases. If <string_view> is not used anywhere, options std_cxx_17 are no more required. * Correction proposal: Use of std_cxx_14, instead of std_cxx_17. Remove the use of <string_view> in Corrosion test cases. Altogether, this allows older compilers to build Corrosion. * Remark: This PR keeps some std_cxx_14 (instead of _17) to keep the need of C++ Standard Library installed on the compilation host. I did not test, but I suppose std_cxx_11 would work too.
ogoffart
requested changes
May 20, 2022
test/cpp2rust/lib.cpp
Outdated
|
|
||
| extern "C" void cpp_function(char const *name) { | ||
| std::string_view const name_sv = name; | ||
| std::cout << "Hello, " << name_sv << "! I'm C++!\n"; | ||
| std::cout << "Hello, " << "my name is lib.cpp" << "! I'm C++!\n"; |
There was a problem hiding this comment.
Suggested change
| std::cout << "Hello, " << "my name is lib.cpp" << "! I'm C++!\n"; | |
| std::cout << "Hello, " << name << "! I'm C++!\n"; |
There was a problem hiding this comment.
Oops :-)
I'll change that. Sorry.
What do you prefer ?
A 2nd commit or a squash ?
|
Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…self.
This PR follows discussion for #183.
Because of both, Corrosion fails to compile on 'old' systems (I did not say vintage :-)).
Investigations:
As Corrosion does not use <string_view>, it's not needed to use this in its test cases.
If <string_view> is not used anywhere, options std_cxx_17 are no more required.
Correction proposal:
Use of std_cxx_14, instead of std_cxx_17.
Remove the use of <string_view> in Corrosion test cases.
Altogether, this allows older compilers to build Corrosion.
Remark:
This PR keeps some std_cxx_14 (instead of _17) to keep the need of C++ Standard Library installed on the compilation host.
I did not test, but I suppose std_cxx_11 would work too.