make FindRust gracefully fail if rustc not found #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier a missing .cargo/bin/rustc would fail with The system cannot find the file specified CMake Error at corrosion/cmake/FindRust.cmake:171 (get_filename_component): get_filename_component called with incorrect number of arguments Now it prints a more descriptive errormessage, sets Rust_FOUND to false and returns. It also sets Rust_FOUND to true if a rust target is successfully created
ratijas
reviewed
Sep 14, 2021
|
@ratijas I have no write access, so I can't merge :) |
|
Thanks |
|
Me neither. I'm a contributor, not collaborator — although was almost promoted to be one. I think I still I lack CMake skill a bit, but gradually getting there :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change is to be able to reuse the FindRust module in a more general setting to see if rust exists.
With this change, it should be able to be used by any other package and afterwards check Rust_FOUND of its existence.
Earlier a missing .cargo/bin/rustc would fail with
Now it prints a more descriptive errormessage, sets Rust_FOUND to false
and returns.
It also sets Rust_FOUND to true if a rust target is successfully created