Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace static mac installer introduction section html with a template file #111

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

ziyiluo
Copy link
Contributor

@ziyiluo ziyiluo commented Apr 9, 2019

Description

  • Removed unused css bits in html file.
  • Replaced version constant with variable. The file will be handled by ant ReplaceTokens tool.

Related issues

  • The goal is to avoid issue corretto-11#10 in future Corretto major versions.

How has this been tested?

Generated the MacOS installer using the gradle task ./gradlew :installers:mac:pkg:generateInstaller, the mac installer has identical welcome (introduction) section contents.

Screen Shot 2019-04-09 at 1 52 34 PM

Platform information

Works on OS: MacOS only
Applies to version [e.g. 8.202.08.2]

Contribution confirmation

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* Removed unused css bits in html file.
* Replaced version constant with variable. The file will be handled by
ant ReplaceTokens tool.
@ziyiluo ziyiluo requested a review from jguo11 April 9, 2019 21:43
Copy link
Contributor

@jguo11 jguo11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ziyiluo ziyiluo merged commit fbf494a into corretto:develop Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants