Fix EC Curve selection by size #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, when a new EC key pair is generated by size (rather than by curve), always select a 'secp*r1' curve. For the standard sizes of 192, 224, 256, 384, and 521 this always matches the behavior of the SunEC provider. This changes the behavior for sizes 192 and 256 from the secp*k1 to the secp*r1 curves (NIST P-192 and P-256) respectively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, when a new EC key pair is generated by size (rather than by curve), always select a 'secp*r1' curve.
For the standard sizes of 192, 224, 256, 384, and 521 this always matches the behavior of the SunEC provider.
This changes the behavior for sizes 192 and 256 from the secpk1 to the secpr1 curves (NIST P-192 and P-256) respectively.
For reference, SunEC uses this table to map from curve sizes to curves. Specifically the curves with the value
PD(Prime Default), are those which are selected. They are:Additionally, this change replaces the certificates used by the integration tests (the JKS files). This change was necessary because the 256 bit certificates incorrectly used the secp256k1 curve which is now disabled in new versions of Java 8.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.