Moves to OpenSSL 1.1.1 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: Yet more fixes to unit test heap errors.
bdonlan
suggested changes
Oct 12, 2019
|
Flakey entropy test failed. Restarted it. |
|
Closing and re-opening to restart tests. |
bdonlan
reviewed
Oct 15, 2019
| if (!RSA_set0_key(r, bn_n, bn_e, bn_d)) { | ||
| throw_openssl(EX_RUNTIME_CRYPTO, "Unable to set key parameters"); | ||
| } else { | ||
| bn_n.releaseOwnership(); |
There was a problem hiding this comment.
Per response on openssl/openssl#10178 this looks correct.
bdonlan
previously approved these changes
Oct 15, 2019
seebees
reviewed
Oct 15, 2019
Co-Authored-By: seebees <ryanemer@amazon.com>
ttjsu-aws
reviewed
Oct 16, 2019
ttjsu-aws
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #44
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.