Improve handling of single byte in TemplateHashSpi #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SalusaSecondus
force-pushed
the
SingleByte
branch
from
5adcec0 to
b2c4a07
Compare
SalusaSecondus
force-pushed
the
SingleByte
branch
from
b2c4a07 to
a970804
Compare
|
Overkill failure is the same heap problem in testing. We've identified this as an issue in the version of JUnit we're using and are still working on fixing it. This failure should not block this PR. |
lrstewart
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #52 and improve performance of single-byte handling in our message digest implementations. It also includes yet another fix to our tests to lower testing heap usage.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.