Fix issue with hashing #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A race condition can cause ACCP’s MessageDigest hashing algorithms to return the same value for different inputs. This patch fixes the issue, and adds new unit tests for both the hash and hmac code to prevent regression.
SalusaSecondus
approved these changes
Apr 21, 2021
scottarc
approved these changes
Apr 21, 2021
SalusaSecondus
added a commit
to SalusaSecondus/amazon-corretto-crypto-provider
that referenced
this pull request
Sep 21, 2021
* develop: Support testing against JDK17 (corretto#165) Add assumeMinimumVersion to InputBuffer tests (corretto#160) Update CHANGELOG for 1.6.1 (corretto#158) Fix issue with hashing (corretto#157) Improve the README (corretto#155)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
A race condition can cause ACCP’s MessageDigest hashing algorithms
to return the same value for different inputs. This patch fixes the
issue, and adds new unit tests for both the hash and hmac code to
prevent regression.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.