Validate that AesGcmSpi#engineInit gets non-null key #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SalusaSecondus
suggested changes
Mar 11, 2021
Co-authored-by: SalusaSecondus <SalusaSecondus@users.noreply.github.com>
|
A test failed in the |
SalusaSecondus
added a commit
to SalusaSecondus/amazon-corretto-crypto-provider
that referenced
this pull request
Apr 15, 2021
* develop: Remove dead code and bump patch version Add logic to generate a classpath file Clarify best practices are local to ACCP Improve documentation (corretto#151) Update CHANGELOG for 1.6.0 (corretto#148) Handle RsaCipher#engineDoFinal with no input bytes (corretto#147) Validate that AesGcmSpi#engineInit gets non-null key (corretto#146) Move to OpenSSL 1.1.1j (corretto#145) Add list of known differences (corretto#137) Better output size estimates. Fixes corretto#135 Move to openssl 1.1.1i (corretto#136) Initial commit of the development guide (corretto#134)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #144
Description of changes: Ensure that all initialization paths in AesGcmSpi validate that the passed Key is non-null, like RsaCipher does.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.