Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android samples #28

Merged
merged 5 commits into from
Apr 22, 2024
Merged

Conversation

rokuz
Copy link

@rokuz rokuz commented Apr 21, 2024

Fixes:

  1. Remove glslang patch. It seems to work without it in new NDK + latest glslang
  2. Workround bug in which CMake lost escaping quotes (in some CMake versions)
  3. Update NDK and fix compilation

NOTE: reason of chaning ALooper_pollAll to ALooper_pollOnce

/**
 * Like ALooper_pollOnce(), but performs all pending callbacks until all
 * data has been consumed or a file descriptor is available with no callback.
 * This function will never return ALOOPER_POLL_CALLBACK.
 *
 * Removed in API 34 as ALooper_pollAll can swallow ALooper_wake calls.
 * Use ALooper_pollOnce instead.
 */
int ALooper_pollAll(int timeoutMillis, int* outFd, int* outEvents, void** outData) __REMOVED_IN(1);

New demo:

photo_2024-04-22_00-28-59

@corporateshark corporateshark merged commit ded9d02 into corporateshark:master Apr 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants