Update testing dependencies #3437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
browser-sync to 2.29.1 cypress to 12.8.1 start-server-and-test to 2.0.0 resolves issue with cypress warning "Couldn't find tsconfig.json. tsconfig-paths will be skipped"
larswmh
approved these changes
Mar 24, 2023
You're welcome! ... and thank you for merging! Contributors should fetch the updated They can also run |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the warning message:
"Opening Cypress...
Couldn't find tsconfig.json. tsconfig-paths will be skipped"
which appears when using Cypress, for instance in the log files of https://github.com/corona-warn-app/cwa-website/actions/workflows/cypress-test-prod.yml
The error no longer occurs when browser-sync is updated to
2.29.1(latest), since this version removes the dependency on"typescript": "^4.6.2"(see BrowserSync/browser-sync@v2.29.0...v2.29.1 where it persists indevDependenciesonly).At the same time:
2.0.0(latest)as part of general maintenance, since these components work together for testing.
Verification
Local test
Execute
npm ci npm testand confirm successful completion.
There should be no message "Couldn't find tsconfig.json. tsconfig-paths will be skipped" in the logs.
GitHub test
Run .github/workflows/build-and-test.yml
Confirm successful completion.
There should be no message "Couldn't find tsconfig.json. tsconfig-paths will be skipped" in the logs after the log message
"Opening Cypress..."
Note
Internal Tracking ID: EXPOSUREAPP-14986