Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update header: Add end of development banner #3436

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

larswmh
Copy link
Member

@larswmh larswmh commented Mar 24, 2023

This PR adds a banner above the header that links to the explanatory FAQ entries about the end of development of the Corona-Warn-App.

image

Screenshots:

Desktop EN:
coronawarn.app/en
coronawarn.app/en/faq

Desktop DE:
coronawarn.app/de
coronawarn.app/de/faq

Mobile EN:
coronawarn.app/en
coronawarn.app/en/faq

Mobile DE:
coronawarn.app/de
coronawarn.app/de/faq


Internal Tracking ID: EXPOSUREAPP-14582

@larswmh larswmh requested a review from a team March 24, 2023 08:03
@larswmh larswmh self-assigned this Mar 24, 2023
Copy link
Contributor

@Ein-Tim Ein-Tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in general, one text suggestion!

src/data/global.json Show resolved Hide resolved
@MikeMcC399

This comment was marked as resolved.

@larswmh
Copy link
Member Author

larswmh commented Mar 24, 2023

@MikeMcC399

You might want to use the same or similar wording as proposed in:

#ramp_down_warn

to keep the statements consistent.

The banner text was intended to be shorter so that it wouldn't take up more space than needed, especially on mobile. I'd say the wording is similar enough.

For comparison:

EN:
Banner: You still can warn other users until April 30, 2023.
FAQ #ramp_down_warn: You can still warn other CWA users about a positive test result until April 30, 2023.

DE:
Banner: Bis einschließlich 30.04.2023 können Sie andere Anwender warnen.
FAQ #ramp_down_warn: Sie können andere CWA-Nutzende noch bis einschließlich 30. April 2023 über ein positives Testergebnis informieren und diese damit warnen.

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Mar 24, 2023

@larswmh / @MikeMcC399 Is both grammatically correct?

"You still can warn […]" vs. "You can still warn […]"

@MikeMcC399
Copy link
Contributor

@Ein-Tim

"You still can warn […]" vs. "You can still warn […]"

Both are correct. The difference of word order causes a change in emphasis.

@larswmh
Copy link
Member Author

larswmh commented Mar 27, 2023

Thanks for the reviews @MikeMcC399 & @Ein-Tim. I'm going to merge this into the update/eod branch now so it's easier for us to merge all related changes into master at once.

@larswmh larswmh merged commit bf6dbd9 into update/eod Mar 27, 2023
@larswmh larswmh deleted the banner/end-of-development branch March 27, 2023 06:55
@MikeMcC399
Copy link
Contributor

@larswmh

Will you also open a PR against update/eod now in case there are any remaining comments not covered in the individual PRs flowing into this branch?

@larswmh larswmh mentioned this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants